-
Notifications
You must be signed in to change notification settings - Fork 511
Define base for assets and support for sub path #1247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Daniel Valdivia <[email protected]>
Signed-off-by: Daniel Valdivia <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Signed-off-by: Daniel Valdivia <[email protected]>
Signed-off-by: Daniel Valdivia <[email protected]>
bexsoft
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested locally, LGTM, For HOP functionality had a demo with @dvaldivia
|
@prakashsvmx it's hard to test this on the yarn server at |
prakashsvmx
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It works fine in 9090.
|
Is it known when will this make it to the release? I tried with latest image ( |
@RafalSkolasinski we haven't added support for this in MinIO yet. This is not a high-priority item for us at the moment. We will get it to it when we can. |
|
I have tried today with the subpath feature ... somehow it's not working My goal is to have a url like https://domain.de/minio <- For UI/console access Can somebody provide an example how to use? |
|
@dvaldivia Where do we have to put this nginx config |
|
Hi @dvaldivia. I'm in the same situation as @Dragos0000. Could you please give us an example of CONSOLE_SUBPATH configuration? I'm using minio version RELEASE.2021-12-20T22-07-16Z |
|
@PedroHRDiniz @Dragos0000 should be fixed by #1384 |






Defines a strict
<base href="/" />tag to load all assets in relation to the rootIntroduces support for the parameter
cpbwhen requesting the index from the target console server, so the hop can replace this in the<base />tagIntroduces
CONSOLE_SUBPATHto instruct the console server to set a base to that valueTo test this
You need the assets, so
make assetsbefore testing this PR.